Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address review comments for src/platform/Darwin from #1497 #1620

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Address review comments for src/platform/Darwin from #1497 #1620

merged 1 commit into from
Jul 21, 2020

Conversation

vivien-apple
Copy link
Contributor

Problem

Address the review comments from sagar for #1497. The PR has landed before I got a chance to fix them.

@restyled-io restyled-io bot mentioned this pull request Jul 16, 2020
Closed
@vivien-apple vivien-apple force-pushed the Darwin_ReviewComments#1497 branch from 6c1f843 to 67ec473 Compare July 16, 2020 11:44
andy31415
andy31415 reviewed Jul 16, 2020
View reviewed changes
src/platform/Darwin/ConfigurationManagerImpl.cpp Outdated
{
PlatformMgr().ScheduleWork(DoFactoryReset);
}
void ConfigurationManagerImpl::_InitiateFactoryReset() {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we log that factory reset not yet implemented or should we add a comment on why this is empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add a log. Seems a good idea to at least see some outputs if it is called.

@woody-apple woody-apple requested a review from andy31415 July 20, 2020 18:15
@vivien-apple vivien-apple force-pushed the Darwin_ReviewComments#1497 branch from 67ec473 to 0a16cb8 Compare July 20, 2020 18:39
@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize

@woody-apple woody-apple merged commit c016638 into project-chip:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelderton jelderton jelderton approved these changes

@woody-apple woody-apple woody-apple approved these changes

@BroderickCarlin BroderickCarlin BroderickCarlin approved these changes

@gerickson gerickson gerickson approved these changes

@mspang mspang mspang approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@andy31415 andy31415 Awaiting requested review from andy31415

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vivien-apple @mspang @gerickson @andy31415 @BroderickCarlin @woody-apple @jelderton